Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: sdk/lib/_internal/pub/test/get/cache_transformed_dependency_test.dart

Issue 792993004: Properly delete cached dependencies that should no longer be cached. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/get/cache_transformed_dependency_test.dart
diff --git a/sdk/lib/_internal/pub/test/get/cache_transformed_dependency_test.dart b/sdk/lib/_internal/pub/test/get/cache_transformed_dependency_test.dart
index 613d9cbd99099a608bd6e98180b76344632abc3a..f19780569eb146c9e17582b15834aa22daca9899 100644
--- a/sdk/lib/_internal/pub/test/get/cache_transformed_dependency_test.dart
+++ b/sdk/lib/_internal/pub/test/get/cache_transformed_dependency_test.dart
@@ -376,6 +376,51 @@ main() {
"lib/foo.dart: true, lib/does/not/exist.dart: false");
endPubServe();
});
+
+ // Regression test for issue 21810.
+ integration("decaches when the dependency is updated to something "
+ "untransformed", () {
+ servePackages((builder) {
+ builder.serveRepoPackage('barback');
+
+ builder.serve("foo", "1.2.3",
+ deps: {'barback': 'any'},
+ pubspec: {'transformers': ['foo']},
+ contents: [
+ d.dir("lib", [
+ d.file("transformer.dart", replaceTransformer("Hello", "Goodbye")),
+ d.file("foo.dart", "final message = 'Hello!';")
+ ])
+ ]);
+
+ builder.serve("foo", "1.2.4",
+ deps: {'barback': 'any'},
+ contents: [
+ d.dir("lib", [
+ d.file("foo.dart", "final message = 'Hello!';")
+ ])
+ ]);
+ });
+
+ d.appDir({"foo": "1.2.3"}).create();
+
+ pubGet(output: contains("Precompiled foo."));
+
+ d.dir(appPath, [
+ d.dir(".pub/deps/debug/foo/lib", [
+ d.file("foo.dart", "final message = 'Goodbye!';")
+ ])
+ ]).validate();
+
+ // Upgrade to the new version of foo.
+ d.appDir({"foo": "1.2.4"}).create();
+
+ pubGet(output: isNot(contains("Precompiled foo.")));
+
+ d.dir(appPath, [
+ d.nothing(".pub/deps/debug/foo")
+ ]).validate();
+ });
}
String replaceTransformer(String input, String output) {
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/entrypoint.dart ('k') | sdk/lib/_internal/pub_generated/lib/src/entrypoint.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698