bound the time waiting for analysis to complete

bound the time waiting for analysis to complete

BUG=
R=paulberry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42228

[danrubel, 2014-12-09 17:58:45]

danrubel@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2014-12-09 19:24:08]

lgtm assuming the "return" is added.

https://codereview.chromium.org/790743003/diff/1/pkg/analysis_server/lib/src/...
File
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
(right):

https://codereview.chromium.org/790743003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart:196:
waitForAnalysis(waitCount - 1);
I believe this needs to be "return waitForAnalysis(waitCount - 1);"

Without the "return", the future will complete the next time the event loop
runs, even if analysis isn't done yet.

[danrubel, 2014-12-09 23:51:53]

https://codereview.chromium.org/790743003/diff/1/pkg/analysis_server/lib/src/...
File
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
(right):

https://codereview.chromium.org/790743003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart:196:
waitForAnalysis(waitCount - 1);
On 2014/12/09 19:24:08, Paul Berry wrote:
> I believe this needs to be "return waitForAnalysis(waitCount - 1);"
> 
> Without the "return", the future will complete the next time the event loop
> runs, even if analysis isn't done yet.

Good catch. Done.

[danrubel, 2014-12-09 23:54:19]

Committed patchset #2 (id:20001) manually as 42228 (presubmit successful).