bound the time waiting for analysis to complete

pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.dart;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/services/completion/arglist_computer.dart';
@@ skipping 159 matching lines @@
             request.replacementLength,
             request.suggestions,
             last));
     if (last) {
       controller.close();
     }
   }
 
   /**
    * Return a future that completes when analysis is complete.
-   * Return `true` if the compilation unit is be resolved.
    */
-  Future<CompilationUnit> waitForAnalysis() {
+  Future<CompilationUnit> waitForAnalysis([int waitCount = 10000]) {
+    //TODO (danrubel) replace this when new API is ready.
+    // I expect the new API to be either a stream of resolution events
+    // or a future that completes when the resolved library element is available
     LibraryElement library = context.getLibraryElement(source);
     if (library != null) {
       CompilationUnit unit =
           context.getResolvedCompilationUnit(source, library);
       if (unit != null) {
         return new Future.value(unit);
       }
     }
-    //TODO (danrubel) Determine if analysis is complete but unit not resolved
-    return new Future(waitForAnalysis);
+    //TODO (danrubel) Remove this HACK
+    if (waitCount > 0) {
+      return new Future(() {
+        waitForAnalysis(waitCount - 1);

[Paul Berry, 2014/12/09 19:24:08]

I believe this needs to be "return waitForAnalysis(waitCount - 1);"

Without the "return", the future will complete the next time the event loop
runs, even if analysis isn't done yet.

[danrubel, 2014/12/09 23:51:52]

Good catch. Done.

+      });
+    }
   }
 }
 
 /**
  * The context in which the completion is requested.
  */
 class DartCompletionRequest extends CompletionRequest {
   /**
    * The analysis context in which the completion is requested.
    */
@@ skipping 64 matching lines @@
   _ReplacementOffsetBuilder(this.request) {
     request.replacementOffset = request.offset;
     request.replacementLength = 0;
   }
 
   visitSimpleIdentifier(SimpleIdentifier node) {
     request.replacementOffset = node.offset;
     request.replacementLength = node.length;
   }
 }