Issue 78713003: Attempt at enabling profiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 78713003: Attempt at enabling profiler (Closed)

Created:
7 years, 1 month ago by Cutch

Modified:
7 years ago

Reviewers:
srdjan, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Attempt at enabling profiler BUG= Committed: https://code.google.com/p/dart/source/detail?r=30478

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -16 lines)			Patch
M	runtime/platform/thread_macos.cc	View	1 chunk	+16 lines, -11 lines	0 comments	Download
M	runtime/vm/profiler.cc	View	2 chunks	+12 lines, -2 lines	0 comments	Download
M	runtime/vm/profiler_macos.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gyp/configurations_android.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gyp/configurations_make.gypi	View	1 chunk	+6 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Cutch

Committed patchset #1 manually as r30478 (presubmit successful).

7 years, 1 month ago (2013-11-20 17:58:03 UTC) #2

srdjan

7 years ago (2013-12-03 22:18:09 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/78713003/diff/1/tools/gyp/configurations_make...
File tools/gyp/configurations_make.gypi (right):

https://codereview.chromium.org/78713003/diff/1/tools/gyp/configurations_make...
tools/gyp/configurations_make.gypi:103: '-fno-omit-frame-pointer',
Adding this used to hurt performance. Have you checked that it has no influence?

Expand Messages | Collapse Messages