Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Unified Diff: runtime/vm/profiler.cc

Issue 78713003: Attempt at enabling profiler (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/profiler.cc
diff --git a/runtime/vm/profiler.cc b/runtime/vm/profiler.cc
index 276c110e9a66d135ef353d7a5f1afd02556e7453..c5ab6ca0d9f607d03c2824977954f270d6f11801 100644
--- a/runtime/vm/profiler.cc
+++ b/runtime/vm/profiler.cc
@@ -16,7 +16,7 @@
namespace dart {
// Notes on locking and signal handling:
-
+//
// The ProfilerManager has a single monitor (monitor_). This monitor guards
// access to the schedule list of isolates (isolates_, isolates_size_, etc).
//
@@ -57,9 +57,19 @@ namespace dart {
// Isolate::SetCurrent which blocks signal delivery while removing the old
// current isolate from the scheduled list and adding the new current isolate
// to the scheduled list.
+//
+
+// Notes on stack frame walking:
+//
+// The sampling profiler will collect up to Sample::kNumStackFrames stack frames
+// The stack frame walking code uses the frame pointer to traverse the stack.
+// If the VM is compiled without frame pointers (which is the default on
+// recent GCC versions with optimizing enabled) the stack walking code will
+// fail (sometimes leading to a crash).
+//
-DEFINE_FLAG(bool, profile, false, "Enable Sampling Profiler");
+DEFINE_FLAG(bool, profile, true, "Enable Sampling Profiler");
bool ProfilerManager::initialized_ = false;
bool ProfilerManager::shutdown_ = false;

Powered by Google App Engine
This is Rietveld 408576698