Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 784853003: include lower relevance suggestions only if they are already cached (Closed)

Created:
6 years ago by danrubel
Modified:
6 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

include lower relevance suggestions only if they are already cached BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=42172

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -26 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart View 3 chunks +13 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 1 2 chunks +17 lines, -17 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/imported_computer.dart View 3 chunks +16 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/services/completion/imported_computer_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
6 years ago (2014-12-08 16:54:34 UTC) #2
scheglov
LGTM
6 years ago (2014-12-08 17:00:36 UTC) #3
danrubel
6 years ago (2014-12-08 18:56:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42172 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698