Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 78223002: Fix dart2js after InternetAddress change (Closed)

Created:
7 years, 1 month ago by Søren Gjesse
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M runtime/bin/socket_patch.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/_internal/lib/io_patch.dart View 2 chunks +9 lines, -0 lines 2 comments Download
M sdk/lib/io/socket.dart View 1 chunk +1 line, -2 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Søren Gjesse
7 years, 1 month ago (2013-11-20 11:53:37 UTC) #1
ngeoffray
LGTM https://codereview.chromium.org/78223002/diff/1/sdk/lib/io/socket.dart File sdk/lib/io/socket.dart (right): https://codereview.chromium.org/78223002/diff/1/sdk/lib/io/socket.dart#newcode114 sdk/lib/io/socket.dart:114: external InternetAddress(String address); No need for factory?
7 years, 1 month ago (2013-11-20 11:57:08 UTC) #2
Anders Johnsen
lgtm https://codereview.chromium.org/78223002/diff/1/sdk/lib/_internal/lib/io_patch.dart File sdk/lib/_internal/lib/io_patch.dart (right): https://codereview.chromium.org/78223002/diff/1/sdk/lib/_internal/lib/io_patch.dart#newcode223 sdk/lib/_internal/lib/io_patch.dart:223: class _InternetAddress { This looks unused.
7 years, 1 month ago (2013-11-20 11:57:18 UTC) #3
Søren Gjesse
https://codereview.chromium.org/78223002/diff/1/sdk/lib/_internal/lib/io_patch.dart File sdk/lib/_internal/lib/io_patch.dart (right): https://codereview.chromium.org/78223002/diff/1/sdk/lib/_internal/lib/io_patch.dart#newcode223 sdk/lib/_internal/lib/io_patch.dart:223: class _InternetAddress { On 2013/11/20 11:57:18, Anders Johnsen wrote: ...
7 years, 1 month ago (2013-11-20 12:02:36 UTC) #4
Søren Gjesse
7 years, 1 month ago (2013-11-20 12:03:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r30459 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698