sdk/lib/io/socket.dart - Issue 78223002: Fix dart2js after InternetAddress change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/io/socket.dart

Issue 78223002: Fix dart2js after InternetAddress change (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/io/socket.dart

diff --git a/sdk/lib/io/socket.dart b/sdk/lib/io/socket.dart

index 11d0ec505bb7773cbc7deda727543f10c67075ec..dfb440e9d6e8d0ceae9804613fd46698f61b9a39 100644

--- a/sdk/lib/io/socket.dart

+++ b/sdk/lib/io/socket.dart

@@ -111,8 +111,7 @@ abstract class InternetAddress {

* (dotted-decimal notation) or IPv6 (hexadecimal representation).

* address [ArgumentError] is thrown.

- factory InternetAddress(String address) =>

- new _InternetAddress.parse(address);

+ external InternetAddress(String address);

ngeoffray 2013/11/20 11:57:08 No need for factory?

Søren Gjesse 2013/11/20 12:02:37 Thats what I tried first, but that fails: sdk/lib

/**

* Perform a reverse dns lookup on the [address], creating a new