Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 770303002: Support non-deoptimizing version of UnboxInt32 for integer definitions. (Closed)

Created:
6 years ago by Vyacheslav Egorov (Google)
Modified:
6 years ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Support non-deoptimizing version of UnboxInt32 for integer definitions. If range analysis infered that integer definition is within Int32 range then it is guaranteed to be either Smi or Mint. BUG=http://dartbug.com/21763 R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=42065

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M runtime/vm/intermediate_language.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +5 lines, -0 lines 2 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +7 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Vyacheslav Egorov (Google)
PTAL
6 years ago (2014-12-02 12:59:46 UTC) #2
Florian Schneider
lgtm https://codereview.chromium.org/770303002/diff/1/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/770303002/diff/1/runtime/vm/intermediate_language_arm.cc#newcode3998 runtime/vm/intermediate_language_arm.cc:3998: LoadInt32FromMint(compiler, value, out, temp, out_of_range); s/out_of_range/NULL/ since it ...
6 years ago (2014-12-02 13:12:04 UTC) #3
Vyacheslav Egorov (Google)
https://codereview.chromium.org/770303002/diff/1/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/770303002/diff/1/runtime/vm/intermediate_language_arm.cc#newcode3998 runtime/vm/intermediate_language_arm.cc:3998: LoadInt32FromMint(compiler, value, out, temp, out_of_range); On 2014/12/02 13:12:03, Florian ...
6 years ago (2014-12-02 13:15:58 UTC) #4
Vyacheslav Egorov (Google)
6 years ago (2014-12-02 13:19:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42065 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698