Issue 765743003: Support use of external strings as inputs to LoadCodeUnitsInstr.

Issue 765743003: Support use of external strings as inputs to LoadCodeUnitsInstr. (Closed)

Created:
6 years ago by zerny-google

Modified:
6 years ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support use of external strings as inputs to LoadCodeUnitsInstr. R=vegorov@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42099

Patch Set 2 : RC and other backends #

Patch Set 5 : safety #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+275 lines, -76 lines)			Patch
M	runtime/vm/assembler_arm.h	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm64.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_mips.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_range_analysis.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1	6 chunks	+25 lines, -24 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1	2 chunks	+10 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	2 chunks	+10 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1	5 chunks	+17 lines, -12 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	2 chunks	+10 lines, -4 lines	0 comments	Download
M	runtime/vm/object.h	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1	2 chunks	+12 lines, -2 lines	0 comments	Download
M	runtime/vm/regexp_assembler.h	View	1 2 3 4	2 chunks	+3 lines, -4 lines	0 comments	Download
M	runtime/vm/regexp_assembler.cc	View	1 2 3 4	5 chunks	+40 lines, -19 lines	0 comments	Download
A	runtime/vm/regexp_test.cc	View		1 chunk	+109 lines, -0 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

https://codereview.chromium.org/765743003/diff/1/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/765743003/diff/1/runtime/vm/intermediate_language.h#newcode4218 runtime/vm/intermediate_language.h:4218: // The array may be tagged or untagged (for ...

6 years ago (2014-11-27 14:27:43 UTC) #2

zerny-google

Thanks for the review. I've addressed the comments and added support for the remaining backends ...

6 years ago (2014-12-01 15:33:30 UTC) #3

zerny-google

6 years ago (2014-12-04 09:27:05 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 (id:80001) manually as 42099 (presubmit successful).

Expand Messages | Collapse Messages