Support use of external strings as inputs to LoadCodeUnitsInstr.

runtime/vm/intermediate_language_ia32.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/intermediate_language.h"
 
 #include "vm/dart_entry.h"
@@ skipping 921 matching lines @@
                                                         bool opt) const {
   const intptr_t kNumInputs = 1;
   return LocationSummary::Make(isolate,
                                kNumInputs,
                                Location::SameAsFirstInput(),
                                LocationSummary::kNoCall);
 }
 
 
 void LoadUntaggedInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
-  Register object = locs()->in(0).reg();
+  Register obj = locs()->in(0).reg();
   Register result = locs()->out(0).reg();
-  __ movl(result, FieldAddress(object, offset()));
+  if (object()->definition()->representation() == kUntagged) {
+    __ movl(result, Address(obj, offset()));
+  } else {
+    __ movl(result, FieldAddress(obj, offset()));

[Vyacheslav Egorov (Google), 2014/11/27 14:27:43]

ASSERT(representation == kTagged)

+  }
 }
 
 
 LocationSummary* LoadClassIdInstr::MakeLocationSummary(Isolate* isolate,
                                                        bool opt) const {
   const intptr_t kNumInputs = 1;
   return LocationSummary::Make(isolate,
                                kNumInputs,
                                Location::RequiresRegister(),
                                LocationSummary::kNoCall);
@@ skipping 2763 matching lines @@
   } else {
     ASSERT(representation() == kTagged);
     summary->set_out(0, Location::RequiresRegister());
   }
 
   return summary;
 }
 
 
 void LoadCodeUnitsInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
+  // The array register points to the backing store for external arrays.
   const Register array = locs()->in(0).reg();
   const Location index = locs()->in(1);
 
   Address element_address = Assembler::ElementAddressForRegIndex(
         IsExternal(), class_id(), index_scale(), array, index.reg());
 
   if ((index_scale() == 1)) {
     __ SmiUntag(index.reg());
   }
 
@@ skipping 3062 matching lines @@
 #if defined(DEBUG)
   __ movl(EDX, Immediate(kInvalidObjectPointer));
 #endif
 }
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_IA32