Incremental compiler: Use addStubs for adding methods.

Incremental compiler: Use addStubs for adding methods.

R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42042

[ahe, 2014-11-26 11:05:06]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[ahe, 2014-11-26 11:05:07]

This may not look like much, but the modified test drags in a whole bunch of
classes and functions used by NoSuchMethodError.

[ahe, 2014-12-01 10:39:40]

Uploaded new patch set.

[Johnni Winther, 2014-12-01 13:40:21]

lgtm

https://codereview.chromium.org/764533002/diff/1/dart/pkg/compiler/lib/src/js...
File dart/pkg/compiler/lib/src/js_emitter/old_emitter/class_builder.dart
(right):

https://codereview.chromium.org/764533002/diff/1/dart/pkg/compiler/lib/src/js...
dart/pkg/compiler/lib/src/js_emitter/old_emitter/class_builder.dart:38: {bool
omitClassDescriptor: false}) {
Change to `bool emitClassDescriptor: true`.

https://codereview.chromium.org/764533002/diff/1/dart/pkg/compiler/lib/src/js...
dart/pkg/compiler/lib/src/js_emitter/old_emitter/class_builder.dart:63:
..addAll(properties);
`..addAll` -> `.addAll` since it isn't used.

https://codereview.chromium.org/764533002/diff/1/dart/pkg/compiler/lib/src/js...
File dart/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/764533002/diff/1/dart/pkg/compiler/lib/src/js...
dart/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1703: var array =
arrayOrFunction;
`array` is never used.

https://codereview.chromium.org/764533002/diff/1/dart/pkg/dart2js_incremental...
File dart/pkg/dart2js_incremental/lib/library_updater.dart (right):

https://codereview.chromium.org/764533002/diff/1/dart/pkg/dart2js_incremental...
dart/pkg/dart2js_incremental/lib/library_updater.dart:669:
r'self.$dart_unsafe_eval.addMethod(#, #, #, #, #)',
I think the many accesses to 'self.$dart_unsafe_eval' properties should be
unified.

[ahe, 2014-12-01 14:03:38]

Thank you, Johnni!

https://codereview.chromium.org/764533002/diff/1/dart/pkg/compiler/lib/src/js...
File dart/pkg/compiler/lib/src/js_emitter/old_emitter/class_builder.dart
(right):

https://codereview.chromium.org/764533002/diff/1/dart/pkg/compiler/lib/src/js...
dart/pkg/compiler/lib/src/js_emitter/old_emitter/class_builder.dart:38: {bool
omitClassDescriptor: false}) {
On 2014/12/01 13:40:20, Johnni Winther wrote:
> Change to `bool emitClassDescriptor: true`.

Will do in follow up.

https://codereview.chromium.org/764533002/diff/1/dart/pkg/compiler/lib/src/js...
dart/pkg/compiler/lib/src/js_emitter/old_emitter/class_builder.dart:63:
..addAll(properties);
On 2014/12/01 13:40:20, Johnni Winther wrote:
> `..addAll` -> `.addAll` since it isn't used.

Will do in follow up.

https://codereview.chromium.org/764533002/diff/1/dart/pkg/compiler/lib/src/js...
File dart/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/764533002/diff/1/dart/pkg/compiler/lib/src/js...
dart/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1703: var array =
arrayOrFunction;
On 2014/12/01 13:40:21, Johnni Winther wrote:
> `array` is never used.

Will do in follow up.

https://codereview.chromium.org/764533002/diff/1/dart/pkg/dart2js_incremental...
File dart/pkg/dart2js_incremental/lib/library_updater.dart (right):

https://codereview.chromium.org/764533002/diff/1/dart/pkg/dart2js_incremental...
dart/pkg/dart2js_incremental/lib/library_updater.dart:669:
r'self.$dart_unsafe_eval.addMethod(#, #, #, #, #)',
On 2014/12/01 13:40:21, Johnni Winther wrote:
> I think the many accesses to 'self.$dart_unsafe_eval' properties should be
> unified.

Will do in follow up.

[ahe, 2014-12-01 14:11:44]

Committed patchset #3 (id:40001) manually as 42042 (presubmit successful).

[ahe, 2014-12-01 15:00:04]

Follow up in https://codereview.chromium.org/764353002/.