Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Side by Side Diff: dart/pkg/compiler/lib/src/js_emitter/old_emitter/class_builder.dart

Issue 764533002: Incremental compiler: Use addStubs for adding methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Merged with r42040. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | dart/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js.js_emitter; 5 part of dart2js.js_emitter;
6 6
7 /** 7 /**
8 * A data structure for collecting fragments of a class definition. 8 * A data structure for collecting fragments of a class definition.
9 */ 9 */
10 class ClassBuilder { 10 class ClassBuilder {
(...skipping 16 matching lines...) Expand all
27 jsAst.Property addProperty(String name, jsAst.Expression value) { 27 jsAst.Property addProperty(String name, jsAst.Expression value) {
28 jsAst.Property property = new jsAst.Property(js.string(name), value); 28 jsAst.Property property = new jsAst.Property(js.string(name), value);
29 properties.add(property); 29 properties.add(property);
30 return property; 30 return property;
31 } 31 }
32 32
33 void addField(String field) { 33 void addField(String field) {
34 fields.add(field); 34 fields.add(field);
35 } 35 }
36 36
37 jsAst.ObjectInitializer toObjectInitializer() { 37 jsAst.ObjectInitializer toObjectInitializer(
38 {bool omitClassDescriptor: false}) {
38 StringBuffer buffer = new StringBuffer(); 39 StringBuffer buffer = new StringBuffer();
39 if (superName != null) { 40 if (superName != null) {
40 buffer.write('$superName'); 41 buffer.write('$superName');
41 if (functionType != null) { 42 if (functionType != null) {
42 buffer.write(':$functionType'); 43 buffer.write(':$functionType');
43 } 44 }
44 buffer.write(';'); 45 buffer.write(';');
45 } 46 }
46 buffer.writeAll(fields, ','); 47 buffer.writeAll(fields, ',');
47 var classData = js.string('$buffer'); 48 var classData = js.string('$buffer');
48 if (fieldMetadata != null) { 49 if (fieldMetadata != null) {
49 // If we need to store fieldMetadata, classData is turned into an array, 50 // If we need to store fieldMetadata, classData is turned into an array,
50 // and the field metadata is appended. So if classData is just a string, 51 // and the field metadata is appended. So if classData is just a string,
51 // there is no field metadata. 52 // there is no field metadata.
52 classData = 53 classData =
53 new jsAst.ArrayInitializer.from([classData]..addAll(fieldMetadata)); 54 new jsAst.ArrayInitializer.from([classData]..addAll(fieldMetadata));
54 } 55 }
55 var fieldsAndProperties = 56 List<jsAst.Property> fieldsAndProperties;
56 [new jsAst.Property(js.string(namer.classDescriptorProperty), 57 if (!omitClassDescriptor) {
57 classData)] 58 fieldsAndProperties = <jsAst.Property>[];
58 ..addAll(properties); 59 fieldsAndProperties.add(
60 new jsAst.Property(
61 js.string(namer.classDescriptorProperty), classData));
62 fieldsAndProperties
63 ..addAll(properties);
64 } else {
65 fieldsAndProperties = properties;
66 }
59 return new jsAst.ObjectInitializer(fieldsAndProperties, isOneLiner: false); 67 return new jsAst.ObjectInitializer(fieldsAndProperties, isOneLiner: false);
60 } 68 }
61
62 } 69 }
OLDNEW
« no previous file with comments | « no previous file | dart/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698