Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 764023002: Incremental compilation of new lazy statics. (Closed)

Created:
6 years ago by ahe
Modified:
6 years ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, kasperl, lukechurch
Visibility:
Public.

Description

Incremental compilation of new lazy statics. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=42243

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Merged with r42240. #

Patch Set 3 : Address comments and also test for needsDefineClass to see if defineClass is needed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -56 lines) Patch
M dart/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 2 5 chunks +53 lines, -34 lines 0 comments Download
M dart/pkg/dart2js_incremental/lib/caching_compiler.dart View 1 1 chunk +5 lines, -2 lines 0 comments Download
M dart/pkg/dart2js_incremental/lib/library_updater.dart View 1 5 chunks +40 lines, -17 lines 0 comments Download
M dart/tests/try/web/incremental_compilation_update_test.dart View 1 2 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ahe
6 years ago (2014-11-28 11:40:32 UTC) #3
Johnni Winther
lgtm https://codereview.chromium.org/764023002/diff/20001/dart/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart File dart/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right): https://codereview.chromium.org/764023002/diff/20001/dart/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart#newcode642 dart/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:642: Isolate.#lazyInitializerProperty = oldIsolate.#lazyInitializerProperty; Long line https://codereview.chromium.org/764023002/diff/20001/dart/tests/try/web/incremental_compilation_update_test.dart File dart/tests/try/web/incremental_compilation_update_test.dart ...
6 years ago (2014-12-09 11:53:52 UTC) #4
ahe
Thank you, Johnni! https://codereview.chromium.org/764023002/diff/20001/dart/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart File dart/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right): https://codereview.chromium.org/764023002/diff/20001/dart/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart#newcode642 dart/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:642: Isolate.#lazyInitializerProperty = oldIsolate.#lazyInitializerProperty; On 2014/12/09 11:53:52, ...
6 years ago (2014-12-10 14:00:05 UTC) #6
ahe
6 years ago (2014-12-10 14:16:25 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:80001) manually as 42243 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698