dart/pkg/dart2js_incremental/lib/caching_compiler.dart - Issue 764023002: Incremental compilation of new lazy statics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/pkg/dart2js_incremental/lib/caching_compiler.dart

Issue 764023002: Incremental compilation of new lazy statics. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address comments and also test for needsDefineClass to see if defineClass is needed. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/pkg/dart2js_incremental/lib/caching_compiler.dart

diff --git a/dart/pkg/dart2js_incremental/lib/caching_compiler.dart b/dart/pkg/dart2js_incremental/lib/caching_compiler.dart

index f364acd1c99ad29a86212a04638121aae1a236dc..2b970c323c6b59c7737a0eb75b83f4145c7eb66f 100644

--- a/dart/pkg/dart2js_incremental/lib/caching_compiler.dart

+++ b/dart/pkg/dart2js_incremental/lib/caching_compiler.dart

@@ -67,8 +67,11 @@ Future<Compiler> reuseCompiler(

JavaScriptBackend backend = compiler.backend;

// Much like a scout, an incremental compiler is always prepared. For

- // mixins, at least.

- backend.emitter.oldEmitter.needsMixinSupport = true;

+ // mixins, classes, and lazy statics, at least.

+ backend.emitter.oldEmitter

+ ..needsDefineClass = true

+ ..needsMixinSupport = true

+ ..needsLazyInitializer = true;

Uri core = Uri.parse("dart:core");

return compiler.libraryLoader.loadLibrary(core).then((_) {