Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 763123002: dart2js: Split TypeTestEmitter into a registry and an emitter. (Closed)

Created:
6 years ago by floitsch
Modified:
6 years ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, sigurdm
Visibility:
Public.

Description

dart2js: Split TypeTestEmitter into a registry and an emitter. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=42027

Patch Set 1 #

Patch Set 2 : Without Emitter #

Patch Set 3 : Without registry. #

Patch Set 4 : full diff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -136 lines) Patch
M pkg/compiler/lib/src/js_backend/native_emitter.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 6 chunks +9 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 3 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart View 1 2 3 3 chunks +137 lines, -120 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/dart2js_incremental/lib/caching_compiler.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
Diffs against https://chromiumcodereview.appspot.com/766743002/ I will move the registry out of the old-emitter directory in a ...
6 years ago (2014-11-27 15:50:34 UTC) #2
karlklose
LGTM.
6 years ago (2014-11-28 09:32:10 UTC) #3
floitsch
6 years ago (2014-11-28 10:43:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 42027 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698