pkg/compiler/lib/src/js_backend/native_emitter.dart - Issue 763123002: dart2js: Split TypeTestEmitter into a registry and an emitter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/native_emitter.dart

Issue 763123002: dart2js: Split TypeTestEmitter into a registry and an emitter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: full diff Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/compiler/lib/src/js_backend/native_emitter.dart

diff --git a/pkg/compiler/lib/src/js_backend/native_emitter.dart b/pkg/compiler/lib/src/js_backend/native_emitter.dart

index d58559459fe383612e018ced02e7d83443bd215e..3c126823f11018939c31b4e0cee3987827abd08d 100644

--- a/pkg/compiler/lib/src/js_backend/native_emitter.dart

+++ b/pkg/compiler/lib/src/js_backend/native_emitter.dart

@@ -112,7 +112,7 @@ class NativeEmitter {

Set<ClassElement> neededByConstant =

emitterTask.interceptorsReferencedFromConstants();

Set<ClassElement> modifiedClasses =

- emitterTask.typeTestEmitter.classesModifiedByEmitRuntimeTypeSupport();

+ emitterTask.typeTestRegistry.classesModifiedByEmitRuntimeTypeSupport();

for (ClassElement classElement in preOrder.reversed) {

// Post-order traversal ensures we visit the subclasses before their

@@ -313,7 +313,7 @@ class NativeEmitter {

classElement, builder);

emitterTask.oldEmitter.classEmitter.emitInstanceMembers(

classElement, builder);

- emitterTask.typeTestEmitter.emitIsTests(classElement, builder);

+ emitterTask.oldEmitter.typeTestEmitter.emitIsTests(classElement, builder);

if (!hasFields &&

builder.properties.length == propertyCount &&

« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/code_emitter_task.dart » ('j') | no next file with comments »