Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 762793002: Disable super-aliases during incremental compilation. (Closed)

Created:
6 years ago by ahe
Modified:
6 years ago
Reviewers:
Johnni Winther, herhut
CC:
reviews_dartlang.org, kasperl, lukechurch
Visibility:
Public.

Description

Disable super-aliases during incremental compilation. R=herhut@google.com, johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=42035

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merged with r42031. #

Patch Set 3 : Renames registerAliasedSuperMember. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -43 lines) Patch
M dart/pkg/compiler/lib/src/js_backend/backend.dart View 1 2 1 chunk +11 lines, -2 lines 0 comments Download
M dart/pkg/compiler/lib/src/ssa/codegen.dart View 1 2 1 chunk +24 lines, -23 lines 0 comments Download
M dart/pkg/dart2js_incremental/lib/library_updater.dart View 4 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ahe
6 years ago (2014-11-26 13:29:07 UTC) #2
herhut
lgtm https://codereview.chromium.org/762793002/diff/1/dart/pkg/compiler/lib/src/js_backend/backend.dart File dart/pkg/compiler/lib/src/js_backend/backend.dart (right): https://codereview.chromium.org/762793002/diff/1/dart/pkg/compiler/lib/src/js_backend/backend.dart#newcode560 dart/pkg/compiler/lib/src/js_backend/backend.dart:560: bool registerAliasedSuperMember(Element member, Selector selector) { I think ...
6 years ago (2014-11-27 09:13:26 UTC) #3
Johnni Winther
lgtm
6 years ago (2014-12-01 08:41:07 UTC) #4
ahe
Thank you, Stephan and Johnni! https://codereview.chromium.org/762793002/diff/1/dart/pkg/compiler/lib/src/js_backend/backend.dart File dart/pkg/compiler/lib/src/js_backend/backend.dart (right): https://codereview.chromium.org/762793002/diff/1/dart/pkg/compiler/lib/src/js_backend/backend.dart#newcode560 dart/pkg/compiler/lib/src/js_backend/backend.dart:560: bool registerAliasedSuperMember(Element member, Selector ...
6 years ago (2014-12-01 09:58:13 UTC) #5
ahe
6 years ago (2014-12-01 10:06:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 42035 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698