Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: dart/pkg/compiler/lib/src/ssa/codegen.dart

Issue 762793002: Disable super-aliases during incremental compilation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Renames registerAliasedSuperMember. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of ssa; 5 part of ssa;
6 6
7 class SsaCodeGeneratorTask extends CompilerTask { 7 class SsaCodeGeneratorTask extends CompilerTask {
8 8
9 final JavaScriptBackend backend; 9 final JavaScriptBackend backend;
10 10
(...skipping 1644 matching lines...) Expand 10 before | Expand all | Expand 10 after
1655 js.PropertyAccess access = 1655 js.PropertyAccess access =
1656 new js.PropertyAccess.field(pop(), fieldName); 1656 new js.PropertyAccess.field(pop(), fieldName);
1657 if (node.isSetter) { 1657 if (node.isSetter) {
1658 use(node.value); 1658 use(node.value);
1659 push(new js.Assignment(access, pop()), node); 1659 push(new js.Assignment(access, pop()), node);
1660 } else { 1660 } else {
1661 push(access, node); 1661 push(access, node);
1662 } 1662 }
1663 } else { 1663 } else {
1664 Selector selector = node.selector; 1664 Selector selector = node.selector;
1665 String methodName; 1665
1666 if (selector.isGetter) { 1666 if (!backend.maybeRegisterAliasedSuperMember(superMethod, selector)) {
1667 // If the selector we need to register a typed getter to the 1667 String methodName;
1668 // [world]. The emitter needs to know if it needs to emit a 1668 if (selector.isGetter) {
1669 // bound closure for a method. 1669 // If the selector we need to register a typed getter to the
1670 TypeMask receiverType = 1670 // [world]. The emitter needs to know if it needs to emit a
1671 new TypeMask.nonNullExact(superClass, compiler.world); 1671 // bound closure for a method.
1672 selector = new TypedSelector(receiverType, selector, compiler.world); 1672 TypeMask receiverType =
1673 // TODO(floitsch): we know the target. We shouldn't register a 1673 new TypeMask.nonNullExact(superClass, compiler.world);
1674 // dynamic getter. 1674 selector = new TypedSelector(receiverType, selector, compiler.world);
1675 registry.registerDynamicGetter(selector); 1675 // TODO(floitsch): we know the target. We shouldn't register a
1676 registry.registerGetterForSuperMethod(node.element); 1676 // dynamic getter.
1677 methodName = backend.namer.invocationName(selector); 1677 registry.registerDynamicGetter(selector);
1678 push( 1678 registry.registerGetterForSuperMethod(node.element);
1679 js.js('#.prototype.#.call(#)', [ 1679 methodName = backend.namer.invocationName(selector);
1680 backend.namer.elementAccess(superClass), 1680 } else {
1681 methodName, visitArguments(node.inputs, start: 0)]), 1681 assert(invariant(node, compiler.hasIncrementalSupport));
1682 node); 1682 methodName = backend.namer.getNameOfInstanceMember(superMethod);
1683 }
1684 push(js.js('#.prototype.#.call(#)',
1685 [backend.namer.elementAccess(superClass),
1686 methodName, visitArguments(node.inputs, start: 0)]),
1687 node);
1683 } else { 1688 } else {
1684 methodName =
1685 backend.namer.getNameOfAliasedSuperMember(superMethod);
1686 backend.registerAliasedSuperMember(superMethod);
1687 use(node.receiver); 1689 use(node.receiver);
1688 push( 1690 push(
1689 js.js('#.#(#)', [ 1691 js.js('#.#(#)', [
1690 pop(), methodName, 1692 pop(), backend.namer.getNameOfAliasedSuperMember(superMethod),
1691 visitArguments(node.inputs, start: 1)]), // Skip receiver argument. 1693 visitArguments(node.inputs, start: 1)]), // Skip receiver argument.
1692 node); 1694 node);
1693 } 1695 }
1694
1695 } 1696 }
1696 } 1697 }
1697 1698
1698 visitFieldGet(HFieldGet node) { 1699 visitFieldGet(HFieldGet node) {
1699 use(node.receiver); 1700 use(node.receiver);
1700 Element element = node.element; 1701 Element element = node.element;
1701 if (node.isNullCheck) { 1702 if (node.isNullCheck) {
1702 // We access a JavaScript member we know all objects besides 1703 // We access a JavaScript member we know all objects besides
1703 // null and undefined have: V8 does not like accessing a member 1704 // null and undefined have: V8 does not like accessing a member
1704 // that does not exist. 1705 // that does not exist.
(...skipping 1011 matching lines...) Expand 10 before | Expand all | Expand 10 after
2716 js.PropertyAccess accessHelper(String name) { 2717 js.PropertyAccess accessHelper(String name) {
2717 Element helper = backend.findHelper(name); 2718 Element helper = backend.findHelper(name);
2718 if (helper == null) { 2719 if (helper == null) {
2719 // For mocked-up tests. 2720 // For mocked-up tests.
2720 return js.js('(void 0).$name'); 2721 return js.js('(void 0).$name');
2721 } 2722 }
2722 registry.registerStaticUse(helper); 2723 registry.registerStaticUse(helper);
2723 return backend.namer.elementAccess(helper); 2724 return backend.namer.elementAccess(helper);
2724 } 2725 }
2725 } 2726 }
OLDNEW
« no previous file with comments | « dart/pkg/compiler/lib/src/js_backend/backend.dart ('k') | dart/pkg/dart2js_incremental/lib/library_updater.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698