Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 762213002: Support top-level field declaration and assignment in analyzer2dart. (Closed)

Created:
6 years ago by Johnni Winther
Modified:
6 years ago
Reviewers:
Paul Berry, sigurdm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support top-level field declaration and assignment in analyzer2dart. BUG= R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=42043

Patch Set 1 #

Patch Set 2 : Update comments #

Total comments: 6

Patch Set 3 : Rebased #

Patch Set 4 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -81 lines) Patch
M pkg/analyzer2dart/lib/src/converted_world.dart View 1 2 3 3 chunks +7 lines, -6 lines 0 comments Download
M pkg/analyzer2dart/lib/src/cps_generator.dart View 1 2 3 4 chunks +63 lines, -5 lines 0 comments Download
M pkg/analyzer2dart/lib/src/modely.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer2dart/test/end2end_data.dart View 1 3 chunks +38 lines, -6 lines 0 comments Download
M pkg/analyzer2dart/test/sexpr_data.dart View 2 chunks +78 lines, -0 lines 0 comments Download
M pkg/analyzer2dart/test/sexpr_test.dart View 3 chunks +26 lines, -7 lines 0 comments Download
M pkg/analyzer2dart/test/test_helper.dart View 2 chunks +6 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/constant_propagation.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 2 3 1 chunk +11 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart View 1 2 3 3 chunks +7 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 3 chunks +32 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 1 chunk +8 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/redundant_phi.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart View 1 2 1 chunk +17 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/optimization.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 1 chunk +8 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/sexpr2_test.dart View 2 chunks +19 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Johnni Winther
6 years ago (2014-11-28 15:02:05 UTC) #2
sigurdm
lgtm https://codereview.chromium.org/762213002/diff/20001/pkg/analyzer2dart/lib/src/cps_generator.dart File pkg/analyzer2dart/lib/src/cps_generator.dart (right): https://codereview.chromium.org/762213002/diff/20001/pkg/analyzer2dart/lib/src/cps_generator.dart#newcode262 pkg/analyzer2dart/lib/src/cps_generator.dart:262: if (hasIrBuilder) { Perhaps make a getter encapsulating ...
6 years ago (2014-12-01 09:06:00 UTC) #3
Johnni Winther
PTAL at the last patch. https://codereview.chromium.org/762213002/diff/20001/pkg/analyzer2dart/lib/src/cps_generator.dart File pkg/analyzer2dart/lib/src/cps_generator.dart (right): https://codereview.chromium.org/762213002/diff/20001/pkg/analyzer2dart/lib/src/cps_generator.dart#newcode262 pkg/analyzer2dart/lib/src/cps_generator.dart:262: if (hasIrBuilder) { On ...
6 years ago (2014-12-01 13:00:39 UTC) #4
sigurdm
Still lgtm
6 years ago (2014-12-01 14:06:32 UTC) #5
Johnni Winther
6 years ago (2014-12-01 14:24:19 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 42043 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698