Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart

Issue 762213002: Support top-level field declaration and assignment in analyzer2dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart
diff --git a/pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart b/pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart
index af68cc362342b90974df7f1d4b94a6d957912f4f..5a0a277ece943677132c490945f0aa43181db1f0 100644
--- a/pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart
+++ b/pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart
@@ -200,22 +200,26 @@ class ASTEmitter
FieldDefinition emitField(tree.FieldDefinition definition,
BuilderContext<Statement> context) {
context.currentElement = definition.element;
- visitStatement(definition.body, context);
- List<Statement> bodyParts;
- for (tree.Variable variable in context.variableNames.keys) {
- if (!context.declaredVariables.contains(variable)) {
- context.addDeclaration(variable);
+ Expression initializer;
+ if (definition.hasInitializer) {
+ visitStatement(definition.body, context);
+ List<Statement> bodyParts;
+ for (tree.Variable variable in context.variableNames.keys) {
+ if (!context.declaredVariables.contains(variable)) {
+ context.addDeclaration(variable);
+ }
}
- }
- if (context.variables.length > 0) {
- bodyParts = new List<Statement>();
- bodyParts.add(new VariableDeclarations(context.variables));
- bodyParts.addAll(context.statements);
- } else {
- bodyParts = context.statements;
+ if (context.variables.length > 0) {
+ bodyParts = new List<Statement>();
+ bodyParts.add(new VariableDeclarations(context.variables));
+ bodyParts.addAll(context.statements);
+ } else {
+ bodyParts = context.statements;
+ }
+ initializer = ensureExpression(bodyParts);
}
- return new FieldDefinition(definition.element, ensureExpression(bodyParts));
+ return new FieldDefinition(definition.element, initializer);
}
/// Returns an expression that will evaluate all of [bodyParts].
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart ('k') | pkg/compiler/lib/src/tree_ir/optimization/optimization.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698