Issue 760933003: Finish parameters matching.

Issue 760933003: Finish parameters matching. (Closed)

Created:
6 years ago by scheglov

Modified:
6 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Finish parameters matching. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42008

Patch Set 1 #

Total comments: 2

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+165 lines, -12 lines)			Patch
M	pkg/analyzer/lib/src/generated/element.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View	3 chunks	+21 lines, -11 lines	0 comments	Download
M	pkg/analyzer/test/generated/incremental_resolver_test.dart	View	5 chunks	+141 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/760933003/diff/1/pkg/analyzer/test/generated/incremental_resolver_test.dart File pkg/analyzer/test/generated/incremental_resolver_test.dart (right): https://codereview.chromium.org/760933003/diff/1/pkg/analyzer/test/generated/incremental_resolver_test.dart#newcode848 pkg/analyzer/test/generated/incremental_resolver_test.dart:848: void test_false_SimpleFormalParameter_named_differentName() { Add tests for adding and ...

6 years ago (2014-11-26 20:45:31 UTC) #2

scheglov

https://codereview.chromium.org/760933003/diff/1/pkg/analyzer/test/generated/incremental_resolver_test.dart File pkg/analyzer/test/generated/incremental_resolver_test.dart (right): https://codereview.chromium.org/760933003/diff/1/pkg/analyzer/test/generated/incremental_resolver_test.dart#newcode848 pkg/analyzer/test/generated/incremental_resolver_test.dart:848: void test_false_SimpleFormalParameter_named_differentName() { On 2014/11/26 20:45:31, Brian Wilkerson wrote: ...

6 years ago (2014-11-26 20:46:53 UTC) #3

scheglov

6 years ago (2014-11-26 20:47:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 42008 (presubmit successful).

Expand Messages | Collapse Messages