Finish parameters matching.

pkg/analyzer/test/generated/incremental_resolver_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library engine.incremental_resolver_test;
 
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/error.dart';
@@ skipping 603 matching lines @@
   }
 
   void test_false_functionTypeAlias_typeParameters_list_remove() {
     _assertCompilationUnitMatches(false, r'''
 typedef F<A, B>();
 ''', r'''
 typedef F<A>();
 ''');
   }
 
+  void test_false_FunctionTypedFormalParameter_parameters_list_add() {
+    _assertCompilationUnitMatches(false, r'''
+main(int callback(int a)) {
+}
+''', r'''
+main(int callback(int a, String b)) {
+}
+''');
+  }
+
+  void test_false_FunctionTypedFormalParameter_parameters_list_remove() {
+    _assertCompilationUnitMatches(false, r'''
+main(int callback(int a, String b)) {
+}
+''', r'''
+main(int callback(int a)) {
+}
+''');
+  }
+
+  void test_false_FunctionTypedFormalParameter_parameterType() {
+    _assertCompilationUnitMatches(false, r'''
+main(int callback(int p)) {
+}
+''', r'''
+main(int callback(String p)) {
+}
+''');
+  }
+
+  void test_false_FunctionTypedFormalParameter_returnType() {
+    _assertCompilationUnitMatches(false, r'''
+main(int callback()) {
+}
+''', r'''
+main(String callback()) {
+}
+''');
+  }
+
+  void test_false_FunctionTypedFormalParameter_wasSimple() {
+    _assertCompilationUnitMatches(false, r'''
+main(int callback) {
+}
+''', r'''
+main(int callback(int a, String b)) {
+}
+''');
+  }
+
   void test_false_implementsClause_add() {
     _assertCompilationUnitMatches(false, r'''
 class A {}
 class B {}
 ''', r'''
 class A {}
 class B implements A {}
 ''');
   }
 
@@ skipping 154 matching lines @@
     _assertCompilationUnitMatches(false, r'''
 library lib;
 part 'unitA.dart';
 part 'unitB.dart';
 ''', r'''
 library lib;
 part 'unitA.dart';
 ''');
   }
 
+  void test_false_SimpleFormalParameter_named_differentName() {

[Brian Wilkerson, 2014/11/26 20:45:31]

Add tests for adding and removing default values for named parameters?

[scheglov, 2014/11/26 20:46:53]

Done.

+    _assertCompilationUnitMatches(false, r'''
+main({int oldName}) {
+}
+''', r'''
+main({int newName}) {
+}
+''');
+  }
+
+  void test_false_SimpleFormalParameter_namedDefault_differentValue() {
+    _assertCompilationUnitMatches(false, r'''
+main({int p: 1}) {
+}
+''', r'''
+main({int p: 2}) {
+}
+''');
+  }
+
+  void test_false_SimpleFormalParameter_optionalDefault_addValue() {
+    _assertCompilationUnitMatches(false, r'''
+main([int p]) {
+}
+''', r'''
+main([int p = 2]) {
+}
+''');
+  }
+
+  void test_false_SimpleFormalParameter_optionalDefault_differentValue() {
+    _assertCompilationUnitMatches(false, r'''
+main([int p = 1]) {
+}
+''', r'''
+main([int p = 2]) {
+}
+''');
+  }
+
+  void test_false_SimpleFormalParameter_optionalDefault_removeValue() {
+    _assertCompilationUnitMatches(false, r'''
+main([int p = 1]) {
+}
+''', r'''
+main([int p]) {
+}
+''');
+  }
+
   void test_false_topLevelAccessor_list_add() {
     _assertCompilationUnitMatches(false, r'''
 get a => 1;
 get b => 2;
 ''', r'''
 get a => 1;
 get b => 2;
 get c => 3;
 ''');
   }
@@ skipping 521 matching lines @@
 }
 ''', r'''
 class T {
   int A = 1;
   int B = 2;
   int C = 3;
 }
 ''');
   }
 
-  void test_true_fieldFormalParameterElement() {
+  void test_true_fieldFormalParameter() {
     _assertCompilationUnitMatches(true, r'''
 class A {
   int field;
   A(this.field);
 }
 ''', r'''
 class A {
   int field;
   A(this.field);
 }
@@ skipping 25 matching lines @@
   }
 
   void test_true_functionTypeAlias_typeParameters_list_same() {
     _assertCompilationUnitMatches(true, r'''
 typedef F<A, B, C>();
 ''', r'''
 typedef F<A, B, C>();
 ''');
   }
 
+  void test_true_FunctionTypedFormalParameter() {
+    _assertCompilationUnitMatches(true, r'''
+main(int callback(int a, String b)) {
+}
+''', r'''
+main(int callback(int a, String b)) {
+}
+''');
+  }
+
   void test_true_implementsClause_same() {
     _assertCompilationUnitMatches(true, r'''
 class A {}
 class B implements A {}
 ''', r'''
 class A {}
 class B implements A {}
 ''');
   }
 
@@ skipping 130 matching lines @@
 library lib;
 part 'unitA.dart';
 part 'unitB.dart';
 ''', r'''
 library lib;
 part 'unitA.dart';
 part 'unitB.dart';
 ''');
   }
 
+  void test_true_SimpleFormalParameter_optional_differentName() {
+    _assertCompilationUnitMatches(true, r'''
+main([int oldName]) {
+}
+''', r'''
+main([int newName]) {
+}
+''');
+  }
+
+  void test_true_SimpleFormalParameter_optionalDefault_differentName() {
+    _assertCompilationUnitMatches(true, r'''
+main([int oldName = 1]) {
+}
+''', r'''
+main([int newName = 1]) {
+}
+''');
+  }
+
+  void test_true_SimpleFormalParameter_required_differentName() {
+    _assertCompilationUnitMatches(true, r'''
+main(int oldName) {
+}
+''', r'''
+main(int newName) {
+}
+''');
+  }
+
   void test_true_topLevelAccessor_list_reorder() {
     _assertCompilationUnitMatches(true, r'''
 set a(x) {}
 set b(x) {}
 set c(x) {}
 ''', r'''
 set c(x) {}
 set a(x) {}
 set b(x) {}
 ''');
@@ skipping 1928 matching lines @@
     _visitList(node.metadata, other.metadata);
     _visitNode(node.identifier, other.identifier);
   }
 
   static void assertSameResolution(CompilationUnit actual,
       CompilationUnit expected) {
     _SameResolutionValidator validator = new _SameResolutionValidator(expected);
     actual.accept(validator);
   }
 }