Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 760383005: Fix parallel move code for swapping SIMD registers on ARM and ARM64. (Closed)

Created:
6 years ago by Florian Schneider
Modified:
6 years ago
Reviewers:
zerny-google
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix parallel move code for swapping SIMD registers on ARM and ARM64. The old code did not swap the full quad-word register, but only half. R=zerny@google.com Committed: https://code.google.com/p/dart/source/detail?r=42044

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M runtime/vm/flow_graph_compiler_arm.cc View 1 1 chunk +13 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Florian Schneider
6 years ago (2014-12-01 15:15:02 UTC) #2
zerny-google
lgtm https://codereview.chromium.org/760383005/diff/1/runtime/vm/flow_graph_compiler_arm.cc File runtime/vm/flow_graph_compiler_arm.cc (right): https://codereview.chromium.org/760383005/diff/1/runtime/vm/flow_graph_compiler_arm.cc#newcode1694 runtime/vm/flow_graph_compiler_arm.cc:1694: QRegister dst = destination.fpu_reg(); Nit: should we keep ...
6 years ago (2014-12-01 15:23:02 UTC) #3
Florian Schneider
https://codereview.chromium.org/760383005/diff/1/runtime/vm/flow_graph_compiler_arm.cc File runtime/vm/flow_graph_compiler_arm.cc (right): https://codereview.chromium.org/760383005/diff/1/runtime/vm/flow_graph_compiler_arm.cc#newcode1694 runtime/vm/flow_graph_compiler_arm.cc:1694: QRegister dst = destination.fpu_reg(); On 2014/12/01 15:23:02, zerny-google wrote: ...
6 years ago (2014-12-01 15:24:40 UTC) #4
Florian Schneider
6 years ago (2014-12-01 15:25:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r42044 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698