Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 75453004: Reapply "This change makes it easier to put type parameters on JavaScript Arrays." (Closed)

Created:
7 years, 1 month ago by sra1
Modified:
7 years, 1 month ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply "This change makes it easier to put type parameters on JavaScript Arrays." Updates recursive_import_test Committed: https://code.google.com/p/dart/source/detail?r=30380

Patch Set 1 #

Patch Set 2 : fix recursive_import_test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -53 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 5 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/lib/core_patch.dart View 2 chunks +3 lines, -16 lines 0 comments Download
M sdk/lib/_internal/lib/js_array.dart View 4 chunks +73 lines, -8 lines 0 comments Download
M sdk/lib/_internal/lib/js_names.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M sdk/lib/_internal/lib/js_primitives.dart View 2 chunks +0 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/mirrors_used_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/value_range_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/iterable_to_list_test.dart View 4 chunks +12 lines, -0 lines 0 comments Download
M tests/utils/dummy_compiler_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M tests/utils/recursive_import_test.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
Committed patchset #2 manually as r30380 (presubmit successful).
7 years, 1 month ago (2013-11-18 22:07:01 UTC) #1
karlklose
7 years, 1 month ago (2013-11-19 07:54:24 UTC) #2
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698