sdk/lib/_internal/lib/js_names.dart - Issue 75453004: Reapply "This change makes it easier to put type parameters on JavaScript Arrays."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/lib/js_names.dart

Issue 75453004: Reapply "This change makes it easier to put type parameters on JavaScript Arrays." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: fix recursive_import_test Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/lib/js_names.dart

diff --git a/sdk/lib/_internal/lib/js_names.dart b/sdk/lib/_internal/lib/js_names.dart

index 5cd89e262d9686943a8516724d852866f54d79ff..90ad3cf871f9cb5c54cf0beb5b90c28d5e5d0fde 100644

--- a/sdk/lib/_internal/lib/js_names.dart

+++ b/sdk/lib/_internal/lib/js_names.dart

@@ -8,8 +8,7 @@ import 'dart:_foreign_helper' show JS, JS_GET_NAME;

import 'dart:_js_helper' show JsCache;

-import 'dart:_js_primitives' show

- markFixedList;

+import 'dart:_interceptors' show JSArray;

/// No-op method that is called to inform the compiler that unmangled named

/// must be preserved.

@@ -75,7 +74,7 @@ List extractKeys(victim) {

}

return result;

})(#, Object.prototype.hasOwnProperty)''', victim);

- return markFixedList(result);

+ return new JSArray.markFixed(result);

}

/**

« no previous file with comments | « sdk/lib/_internal/lib/js_array.dart ('k') | sdk/lib/_internal/lib/js_primitives.dart » ('j') | no next file with comments »