Avoid instantiating FileLocations where possible in source_span.

Avoid instantiating FileLocations where possible in source_span.

R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41921

[Bob Nystrom, 2014-11-21 23:38:18]

Couple of things, then LGTM.

https://codereview.chromium.org/754463002/diff/1/pkg/source_span/lib/src/file...
File pkg/source_span/lib/src/file.dart (right):

https://codereview.chromium.org/754463002/diff/1/pkg/source_span/lib/src/file...
pkg/source_span/lib/src/file.dart:223: var d =
_start.compareTo(otherFile._start);
"d" seems random to me. How about "result"?

https://codereview.chromium.org/754463002/diff/1/pkg/source_span/lib/src/file...
pkg/source_span/lib/src/file.dart:227: SourceSpan union(SourceSpan other) {
Is this an override? If not, doc comment.

[nweiz, 2014-11-21 23:47:27]

Code review changes

[nweiz, 2014-11-21 23:47:32]

https://codereview.chromium.org/754463002/diff/1/pkg/source_span/lib/src/file...
File pkg/source_span/lib/src/file.dart (right):

https://codereview.chromium.org/754463002/diff/1/pkg/source_span/lib/src/file...
pkg/source_span/lib/src/file.dart:223: var d =
_start.compareTo(otherFile._start);
On 2014/11/21 23:38:18, Bob Nystrom wrote:
> "d" seems random to me. How about "result"?

Done. This is a relic of the old source_maps code.

https://codereview.chromium.org/754463002/diff/1/pkg/source_span/lib/src/file...
pkg/source_span/lib/src/file.dart:227: SourceSpan union(SourceSpan other) {
On 2014/11/21 23:38:17, Bob Nystrom wrote:
> Is this an override? If not, doc comment.

Yes, it is.

[nweiz, 2014-11-21 23:50:47]

Committed patchset #2 (id:20001) manually as 41921 (presubmit successful).