pkg/source_span/CHANGELOG.md - Issue 754463002: Avoid instantiating FileLocations where possible in source_span.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: pkg/source_span/CHANGELOG.md

Issue 754463002: Avoid instantiating FileLocations where possible in source_span. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
	1 # 1.0.2

	2

	3 * Avoid unintentionally allocating extra objects for internal `FileSpan`

	4 operations.

	5

	6 * Ensure that `SourceSpan.operator==` works on arbitrary `Object`s.

	7

1 # 1.0.1	8 # 1.0.1

2	9

3 * Use a more compact internal representation for `FileSpan`.	10 * Use a more compact internal representation for `FileSpan`.

4	11

5 # 1.0.0	12 # 1.0.0

6	13

7 This package was extracted from the	14 This package was extracted from the

8 [`source_maps`](http://pub.dartlang.org/packages/source_maps) package, but the	15 [`source_maps`](http://pub.dartlang.org/packages/source_maps) package, but the

9 API has many differences. Among them:	16 API has many differences. Among them:

10	17

(...skipping 17 matching lines...) Expand all Loading...
28 `SourceSpan.message` and `SourceFile.message`, respectively. Rather than	35 `SourceSpan.message` and `SourceFile.message`, respectively. Rather than

29 taking both a `useColor` and a `color` parameter, they now take a single	36 taking both a `useColor` and a `color` parameter, they now take a single

30 `color` parameter that controls both whether and which color is used.	37 `color` parameter that controls both whether and which color is used.

31	38

32 * `Span.isIdentifier` has been removed. This property doesn't make sense outside	39 * `Span.isIdentifier` has been removed. This property doesn't make sense outside

33 of a source map context.	40 of a source map context.

34	41

35 * `SourceFileSegment` has been removed. This class wasn't widely used and was	42 * `SourceFileSegment` has been removed. This class wasn't widely used and was

36 inconsistent in its choice of which parameters were considered relative and	43 inconsistent in its choice of which parameters were considered relative and

37 which absolute.	44 which absolute.

OLD	NEW

« no previous file with comments | « no previous file | pkg/source_span/lib/src/file.dart » ('j') | no next file with comments »