Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 754383002: Revert "Integrate the Irregexp Regular Expression Engine." (Closed)

Created:
6 years ago by zerny-google
Modified:
6 years ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Revert "Integrate the Irregexp Regular Expression Engine." This reverts commit https://code.google.com/p/dart/source/detail?r=41949 TBR=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41950

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4287 lines, -6477 lines) Patch
M runtime/lib/regexp.cc View 3 chunks +2 lines, -36 lines 0 comments Download
M runtime/lib/regexp_patch.dart View 5 chunks +3 lines, -123 lines 0 comments Download
M runtime/vm/compiler.cc View 12 chunks +17 lines, -130 lines 0 comments Download
M runtime/vm/debugger.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph.h View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 4 chunks +4 lines, -20 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 6 chunks +1 line, -37 lines 0 comments Download
M runtime/vm/flow_graph_range_analysis.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 4 chunks +0 lines, -36 lines 0 comments Download
M runtime/vm/growable_array.h View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/il_printer.cc View 2 chunks +0 lines, -35 lines 0 comments Download
M runtime/vm/intermediate_language.h View 15 chunks +0 lines, -208 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 4 chunks +0 lines, -65 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 3 chunks +0 lines, -164 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 3 chunks +0 lines, -103 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 3 chunks +0 lines, -178 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 3 chunks +0 lines, -105 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 3 chunks +0 lines, -115 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 2 chunks +0 lines, -36 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 2 chunks +0 lines, -36 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 2 chunks +1 line, -36 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 2 chunks +0 lines, -38 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 2 chunks +0 lines, -36 lines 0 comments Download
M runtime/vm/method_recognizer.h View 2 chunks +0 lines, -3 lines 0 comments Download
M runtime/vm/object.h View 8 chunks +1 line, -49 lines 0 comments Download
M runtime/vm/object.cc View 6 chunks +0 lines, -36 lines 0 comments Download
M runtime/vm/parser.h View 5 chunks +0 lines, -9 lines 0 comments Download
M runtime/vm/parser.cc View 5 chunks +0 lines, -30 lines 0 comments Download
M runtime/vm/raw_object.h View 3 chunks +1 line, -7 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/vm/regexp.h View 43 chunks +439 lines, -387 lines 0 comments Download
M runtime/vm/regexp.cc View 192 chunks +1573 lines, -1307 lines 0 comments Download
M runtime/vm/regexp_assembler.h View 2 chunks +74 lines, -536 lines 0 comments Download
M runtime/vm/regexp_assembler.cc View 1 chunk +4 lines, -1795 lines 0 comments Download
M runtime/vm/regexp_ast.h View 7 chunks +181 lines, -187 lines 0 comments Download
M runtime/vm/regexp_ast.cc View 10 chunks +103 lines, -101 lines 0 comments Download
M runtime/vm/regexp_parser.h View 8 chunks +55 lines, -53 lines 0 comments Download
M runtime/vm/regexp_parser.cc View 48 chunks +205 lines, -280 lines 0 comments Download
M runtime/vm/symbols.h View 4 chunks +0 lines, -38 lines 0 comments Download
M runtime/vm/unibrow.h View 2 chunks +29 lines, -25 lines 0 comments Download
M runtime/vm/unibrow.cc View 13 chunks +1574 lines, -47 lines 0 comments Download
M runtime/vm/unibrow-inl.h View 3 chunks +10 lines, -6 lines 0 comments Download
M runtime/vm/unicode.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/vm_sources.gypi View 2 chunks +0 lines, -11 lines 0 comments Download
M tests/co19/co19-runtime.status View 2 chunks +6 lines, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
zerny-google
Committed patchset #1 (id:1) manually as 41950.
6 years ago (2014-11-25 13:37:17 UTC) #1
Florian Schneider
6 years ago (2014-11-25 13:38:06 UTC) #2
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698