Explicitly clear out the IC-data register in ExecuteMatch.

Explicitly clear out the IC-data register in ExecuteMatch.

The register value is unknown on entry to ExecuteMatch and needs to be
made GC safe before calling the matching function which could be a lazy
stub.

R=vegorov@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=41996

[zerny-google, 2014-11-26 14:07:00]

PTAL

[Vyacheslav Egorov (Google), 2014-11-26 14:26:18]

LGTMwC

https://codereview.chromium.org/753743005/diff/1/runtime/vm/intrinsifier_mips.cc
File runtime/vm/intrinsifier_mips.cc (right):

https://codereview.chromium.org/753743005/diff/1/runtime/vm/intrinsifier_mips...
runtime/vm/intrinsifier_mips.cc:2099: __ xor_(S5, S5, S5);
mov(S5, ZR) maybe?

https://codereview.chromium.org/753743005/diff/1/runtime/vm/intrinsifier_x64.cc
File runtime/vm/intrinsifier_x64.cc (right):

https://codereview.chromium.org/753743005/diff/1/runtime/vm/intrinsifier_x64....
runtime/vm/intrinsifier_x64.cc:1948: __ xorl(RCX, RCX);
xor*q*

[zerny-google, 2014-11-26 14:33:55]

Thanks for the review. Issues addressed in latest PS.

https://codereview.chromium.org/753743005/diff/1/runtime/vm/intrinsifier_mips.cc
File runtime/vm/intrinsifier_mips.cc (right):

https://codereview.chromium.org/753743005/diff/1/runtime/vm/intrinsifier_mips...
runtime/vm/intrinsifier_mips.cc:2099: __ xor_(S5, S5, S5);
On 2014/11/26 14:26:17, Vyacheslav Egorov (Google) wrote:
> mov(S5, ZR) maybe?

Done.

https://codereview.chromium.org/753743005/diff/1/runtime/vm/intrinsifier_x64.cc
File runtime/vm/intrinsifier_x64.cc (right):

https://codereview.chromium.org/753743005/diff/1/runtime/vm/intrinsifier_x64....
runtime/vm/intrinsifier_x64.cc:1948: __ xorl(RCX, RCX);
On 2014/11/26 14:26:17, Vyacheslav Egorov (Google) wrote:
> xor*q*

Thanks!

[zerny-google, 2014-11-26 14:40:24]

Committed patchset #2 (id:20001) manually as 41996 (presubmit successful).