Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: runtime/vm/intrinsifier_x64.cc

Issue 753743005: Explicitly clear out the IC-data register in ExecuteMatch. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: x64 fix and mips mov Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intrinsifier_mips.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier_x64.cc
diff --git a/runtime/vm/intrinsifier_x64.cc b/runtime/vm/intrinsifier_x64.cc
index 2cb9d36d92c51c1b19641e71a7a31c5c111d06da..7f9b8dea71859a0ffe3531cfefe0388f70e82b91 100644
--- a/runtime/vm/intrinsifier_x64.cc
+++ b/runtime/vm/intrinsifier_x64.cc
@@ -1929,7 +1929,7 @@ void Intrinsifier::JSRegExp_ExecuteMatch(Assembler* assembler) {
// Incoming registers:
// RAX: Function. (Will be loaded with the specialized matcher function.)
- // RCX: IC-Data. (Will be preserved.)
+ // RCX: Unknown. (Must be GC safe on tail call.)
// R10: Arguments descriptor. (Will be preserved.)
// Load the specialized function pointer into RAX. Leverage the fact the
@@ -1945,6 +1945,7 @@ void Intrinsifier::JSRegExp_ExecuteMatch(Assembler* assembler) {
// in RAX, the argument descriptor in R10, and IC-Data in RCX.
static const intptr_t arg_count = RegExpMacroAssembler::kParamCount;
__ LoadObject(R10, Array::Handle(ArgumentsDescriptor::New(arg_count)), PP);
+ __ xorq(RCX, RCX);
// Tail-call the function.
__ movq(RDI, FieldAddress(RAX, Function::instructions_offset()));
« no previous file with comments | « runtime/vm/intrinsifier_mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698