Issue 75203003: Remove intrinsified version of fsin, fcos. The optimized code calls into runtime, which may use dif…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 75203003: Remove intrinsified version of fsin, fcos. The optimized code calls into runtime, which may use dif… (Closed)

Created:
7 years, 1 month ago by srdjan

Modified:
7 years, 1 month ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Remove intrinsified version of fsin, fcos. The optimized code calls into runtime, which may use different way to compute sin/cos. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=30367

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -127 lines)			Patch
M	runtime/vm/intrinsifier.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View	1 chunk	+0 lines, -54 lines	0 comments	Download
M	runtime/vm/intrinsifier_mips.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	2 chunks	+0 lines, -55 lines	0 comments	Download

Total messages: 4 (0 generated)

Cutch

On 2013/11/18 18:37:59, srdjan wrote: lgtm but what about removing the sqrt intrinsic as well?

7 years, 1 month ago (2013-11-18 18:40:32 UTC) #2

srdjan

On 2013/11/18 18:40:32, Cutch wrote: > On 2013/11/18 18:37:59, srdjan wrote: > > lgtm but ...

7 years, 1 month ago (2013-11-18 18:56:04 UTC) #3

srdjan

7 years, 1 month ago (2013-11-18 18:56:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r30367 (presubmit successful).