Remove intrinsified version of fsin, fcos. The optimized code calls into runtime, which may use dif…

runtime/vm/intrinsifier_x64.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/intrinsifier.h"
 
 #include "vm/assembler.h"
@@ skipping 1178 matching lines @@
   __ ret();
   __ Bind(&is_zero);
   // Check for negative zero (get the sign bit).
   __ movmskpd(RAX, XMM0);
   __ testq(RAX, Immediate(1));
   __ j(NOT_ZERO, &is_true, Assembler::kNearJump);
   __ jmp(&is_false, Assembler::kNearJump);
 }
 
 
-enum TrigonometricFunctions {
-  kSine,
-  kCosine,
-};
-
-
-static void EmitTrigonometric(Assembler* assembler,
-                              TrigonometricFunctions kind) {
-  Label fall_through, is_smi, double_op;
-  TestLastArgumentIsDouble(assembler, &is_smi, &fall_through);
-  // Argument is double and is in EAX.
-  __ fldl(FieldAddress(RAX, Double::value_offset()));
-  __ Bind(&double_op);
-  switch (kind) {
-    case kSine:   __ fsin(); break;
-    case kCosine: __ fcos(); break;
-    default:
-      UNREACHABLE();
-  }
-  const Class& double_class = Class::Handle(
-      Isolate::Current()->object_store()->double_class());
-  Label alloc_failed;
-  __ TryAllocate(double_class,
-                 &alloc_failed,
-                 Assembler::kNearJump,
-                 RAX,  // Result register.
-                 kNoRegister);  // Pool pointer might not be loaded.
-  __ fstpl(FieldAddress(RAX, Double::value_offset()));
-  __ ret();
-
-  __ Bind(&is_smi);  // smi -> double.
-  __ SmiUntag(RAX);
-  __ pushq(RAX);
-  __ fildl(Address(RSP, 0));
-  __ popq(RAX);
-  __ jmp(&double_op);
-
-  __ Bind(&alloc_failed);
-  __ ffree(0);
-  __ fincstp();
-
-  __ Bind(&fall_through);
-}
-
-
 void Intrinsifier::Double_toInt(Assembler* assembler) {
   __ movq(RAX, Address(RSP, +1 * kWordSize));
   __ movsd(XMM0, FieldAddress(RAX, Double::value_offset()));
   __ cvttsd2siq(RAX, XMM0);
   // Overflow is signalled with minint.
   Label fall_through;
   // Check for overflow and that it fits into Smi.
   __ movq(RCX, RAX);
   __ shlq(RCX, Immediate(1));
   __ j(OVERFLOW, &fall_through, Assembler::kNearJump);
@@ skipping 20 matching lines @@
   __ movsd(FieldAddress(RAX, Double::value_offset()), XMM0);
   __ ret();
   __ Bind(&is_smi);
   __ SmiUntag(RAX);
   __ cvtsi2sd(XMM1, RAX);
   __ jmp(&double_op);
   __ Bind(&fall_through);
 }
 
 
-void Intrinsifier::Math_sin(Assembler* assembler) {
-  EmitTrigonometric(assembler, kSine);
-}
-
-
-void Intrinsifier::Math_cos(Assembler* assembler) {
-  EmitTrigonometric(assembler, kCosine);
-}
-
-
 //    var state = ((_A * (_state[kSTATE_LO])) + _state[kSTATE_HI]) & _MASK_64;
 //    _state[kSTATE_LO] = state & _MASK_32;
 //    _state[kSTATE_HI] = state >> 32;
 void Intrinsifier::Random_nextState(Assembler* assembler) {
   const Library& math_lib = Library::Handle(Library::MathLibrary());
   ASSERT(!math_lib.IsNull());
   const Class& random_class = Class::Handle(
       math_lib.LookupClassAllowPrivate(Symbols::_Random()));
   ASSERT(!random_class.IsNull());
   const Field& state_field = Field::ZoneHandle(
@@ skipping 394 matching lines @@
 
 void Intrinsifier::TwoByteString_equality(Assembler* assembler) {
   StringEquality(assembler, kTwoByteStringCid);
 }
 
 #undef __
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64