Issue 21613. Fix for renaming FieldFormalParameterElement.

Issue 21613. Fix for renaming FieldFormalParameterElement.

R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21613

Committed: https://code.google.com/p/dart/source/detail?r=41929

[Paul Berry, 2014-11-24 14:31:17]

lgtm with additional test.

https://codereview.chromium.org/749173002/diff/1/pkg/analysis_server/test/edi...
File pkg/analysis_server/test/edit/refactoring_test.dart (right):

https://codereview.chromium.org/749173002/diff/1/pkg/analysis_server/test/edi...
pkg/analysis_server/test/edit/refactoring_test.dart:1115: 
I think we need one additional test to make sure that named parameters are
properly updated at the call site.  E.g.:

  class A {
    var test = 0;
    A({this.test}); // RENAME HERE
    f() {
      print(test);
    }
  }
  main() {
    new A(test: 1).f(); // SHOULD BE UPDATED
  }

Or is this already tested elsewhere?

[scheglov, 2014-11-24 16:00:14]

https://codereview.chromium.org/749173002/diff/1/pkg/analysis_server/test/edi...
File pkg/analysis_server/test/edit/refactoring_test.dart (right):

https://codereview.chromium.org/749173002/diff/1/pkg/analysis_server/test/edi...
pkg/analysis_server/test/edit/refactoring_test.dart:1115: 
On 2014/11/24 14:31:17, Paul Berry wrote:
> I think we need one additional test to make sure that named parameters are
> properly updated at the call site.  E.g.:
> 
>   class A {
>     var test = 0;
>     A({this.test}); // RENAME HERE
>     f() {
>       print(test);
>     }
>   }
>   main() {
>     new A(test: 1).f(); // SHOULD BE UPDATED
>   }
> 
> Or is this already tested elsewhere?

Done.

[scheglov, 2014-11-24 16:00:34]

Committed patchset #2 (id:20001) manually as 41929 (presubmit successful).