Issue 21613. Fix for renaming FieldFormalParameterElement.

pkg/analysis_server/test/edit/refactoring_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.edit.refactoring;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/edit/edit_domain.dart';
 import 'package:analysis_server/src/protocol.dart';
@@ skipping 1053 matching lines @@
 }
 ''');
       });
     });
   }
 
   test_classMember_field() {
     addTestFile('''
 class A {
   var test = 0;
+  A(this.test);
   main() {
     print(test);
   }
 }
 ''');
     return assertSuccessfulRefactoring(() {
       return sendRenameRequest('test = 0', 'newName');
     }, '''
 class A {
   var newName = 0;
+  A(this.newName);
   main() {
     print(newName);
   }
+}
+''');
+  }
+
+  test_classMember_field_onFieldFormalParameter() {
+    addTestFile('''
+class A {
+  var test = 0;
+  A(this.test);
+  main() {
+    print(test);
+  }
+}
+''');
+    return assertSuccessfulRefactoring(() {
+      return sendRenameRequest('test);', 'newName');
+    }, '''
+class A {
+  var newName = 0;
+  A(this.newName);
+  main() {
+    print(newName);
+  }
 }
 ''');
   }
 

[Paul Berry, 2014/11/24 14:31:17]

I think we need one additional test to make sure that named parameters are
properly updated at the call site.  E.g.:

  class A {
    var test = 0;
    A({this.test}); // RENAME HERE
    f() {
      print(test);
    }
  }
  main() {
    new A(test: 1).f(); // SHOULD BE UPDATED
  }

Or is this already tested elsewhere?

[scheglov, 2014/11/24 16:00:14]

Done.

   test_classMember_getter() {
     addTestFile('''
 class A {
   get test => 0;
   main() {
     print(test);
   }
 }
 ''');
     return assertSuccessfulRefactoring(() {
@@ skipping 468 matching lines @@
   }
 
   @override
   void setUp() {
     super.setUp();
     server.handlers = [new EditDomainHandler(server),];
     createProject();
     handler = new EditDomainHandler(server);
   }
 }