Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 746993002: Avoid patching in dart2dart. (Closed)

Created:
6 years, 1 month ago by Johnni Winther
Modified:
6 years, 1 month ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Avoid patching in dart2dart. BUG=http://dartbug.com/21441 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=41901

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+395 lines, -232 lines) Patch
M pkg/analyzer2dart/lib/src/modely.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 4 chunks +17 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 1 4 chunks +76 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart View 2 chunks +7 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 5 chunks +18 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +1 line, -0 lines 0 comments Download
A pkg/compiler/lib/src/js_backend/patch_resolver.dart View 1 chunk +159 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 5 chunks +74 lines, -201 lines 0 comments Download
M pkg/compiler/lib/src/warnings.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 2 chunks +2 lines, -1 line 0 comments Download
M tests/corelib/corelib.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 4 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
6 years, 1 month ago (2014-11-21 11:07:13 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/746993002/diff/1/pkg/compiler/lib/src/dart_backend/backend.dart File pkg/compiler/lib/src/dart_backend/backend.dart (right): https://codereview.chromium.org/746993002/diff/1/pkg/compiler/lib/src/dart_backend/backend.dart#newcode50 pkg/compiler/lib/src/dart_backend/backend.dart:50: /// The set of visible platform classes that ...
6 years, 1 month ago (2014-11-21 12:14:49 UTC) #3
Johnni Winther
https://codereview.chromium.org/746993002/diff/1/pkg/compiler/lib/src/dart_backend/backend.dart File pkg/compiler/lib/src/dart_backend/backend.dart (right): https://codereview.chromium.org/746993002/diff/1/pkg/compiler/lib/src/dart_backend/backend.dart#newcode50 pkg/compiler/lib/src/dart_backend/backend.dart:50: /// The set of visible platform classes that are ...
6 years, 1 month ago (2014-11-21 13:20:32 UTC) #4
Johnni Winther
6 years, 1 month ago (2014-11-21 13:44:02 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 41901 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698