pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart - Issue 746993002: Avoid patching in dart2dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart

Issue 746993002: Avoid patching in dart2dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart

diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart

index 90f97e2114c335e7435a8b0bdf0d0438b592e449..17b3d699b1d4be9e5013547a12b6a2fa737b3e58 100644

--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart

+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart

@@ -141,7 +141,6 @@ class IrBuilderVisitor extends ResolvedVisitor<ir.Primitive>

assert(invariant(element, element.isImplementation));

ast.FunctionExpression function = element.node;

assert(function != null);

- assert(!function.modifiers.isExternal);

assert(elements[function] != null);

DetectClosureVariables closureLocals = new DetectClosureVariables(elements);