Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 745573002: Create generic check methods for RangeError causing checks. (Closed)

Created:
6 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
6 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Create generic check methods for RangeError causing checks. Use them where appropriate in core libraries. There are many more possible uses in vm- and dart2js-libraries. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=41893

Patch Set 1 #

Patch Set 2 : Use range-check functions for newly introduced range checks. #

Patch Set 3 : Typo and trailing whitespace. #

Total comments: 1

Patch Set 4 : Fix long line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -207 lines) Patch
M sdk/lib/async/stream.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M sdk/lib/collection/iterable.dart View 2 chunks +13 lines, -10 lines 0 comments Download
M sdk/lib/collection/list.dart View 5 chunks +11 lines, -24 lines 0 comments Download
M sdk/lib/collection/queue.dart View 1 chunk +1 line, -3 lines 0 comments Download
M sdk/lib/collection/set.dart View 1 chunk +6 lines, -5 lines 0 comments Download
M sdk/lib/convert/ascii.dart View 1 2 5 chunks +7 lines, -38 lines 0 comments Download
M sdk/lib/convert/latin1.dart View 2 chunks +2 lines, -12 lines 0 comments Download
M sdk/lib/convert/utf.dart View 1 2 chunks +4 lines, -16 lines 0 comments Download
M sdk/lib/core/errors.dart View 1 2 3 chunks +75 lines, -4 lines 0 comments Download
M sdk/lib/core/iterable.dart View 3 chunks +17 lines, -17 lines 0 comments Download
M sdk/lib/core/string.dart View 3 chunks +4 lines, -11 lines 0 comments Download
M sdk/lib/internal/iterable.dart View 10 chunks +31 lines, -41 lines 0 comments Download
M sdk/lib/internal/list.dart View 1 chunk +1 line, -3 lines 0 comments Download
M sdk/lib/internal/lists.dart View 1 2 3 1 chunk +6 lines, -15 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
6 years, 1 month ago (2014-11-20 12:26:12 UTC) #2
Søren Gjesse
lgtm https://codereview.chromium.org/745573002/diff/40001/sdk/lib/internal/lists.dart File sdk/lib/internal/lists.dart (right): https://codereview.chromium.org/745573002/diff/40001/sdk/lib/internal/lists.dart#newcode86 sdk/lib/internal/lists.dart:86: throw new RangeError.range(length, 0, a.length - start, "length", ...
6 years, 1 month ago (2014-11-20 13:56:29 UTC) #3
Lasse Reichstein Nielsen
6 years, 1 month ago (2014-11-21 10:29:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 41893 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698