sdk/lib/internal/list.dart - Issue 745573002: Create generic check methods for RangeError causing checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/internal/list.dart

Issue 745573002: Create generic check methods for RangeError causing checks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix long line Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/internal/list.dart

diff --git a/sdk/lib/internal/list.dart b/sdk/lib/internal/list.dart

index 71e08f80de5d9a483de247ed59f7c823c2fa0a88..6b94c6cbbf9197b3a135d78eedbbe90ae15fa1c0 100644

--- a/sdk/lib/internal/list.dart

+++ b/sdk/lib/internal/list.dart

@@ -238,9 +238,7 @@ class _ListIndicesIterable extends ListIterable<int> {

int get length => _backedList.length;

int elementAt(int index) {

- if (index < 0 || index >= length) {

- throw new RangeError.index(index, this);

- }

+ RangeError.checkValidIndex(index, this);

return index;

}

« no previous file with comments | « sdk/lib/internal/iterable.dart ('k') | sdk/lib/internal/lists.dart » ('j') | no next file with comments »