Issue 745203002: - Make array immutable first, then canonicalize it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 745203002: - Make array immutable first, then canonicalize it. (Closed)

Created:
6 years, 1 month ago by Ivan Posva

Modified:
6 years, 1 month ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Make array immutable first, then canonicalize it. - When serializing canonical objects, then inline the referenced objects, so that you can canonicalize them when deserializing. - Reenabled language/enum_const_test. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=41881

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -12 lines)			Patch
M	runtime/vm/parser.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	5 chunks	+7 lines, -2 lines	0 comments	Download
M	runtime/vm/snapshot.cc	View	5 chunks	+20 lines, -6 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Ivan Posva

6 years, 1 month ago (2014-11-21 07:18:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r41881 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages