Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: runtime/vm/parser.cc

Issue 745203002: - Make array immutable first, then canonicalize it. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/raw_object_snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 41861)
+++ runtime/vm/parser.cc (working copy)
@@ -10784,8 +10784,8 @@
}
const_list.SetAt(i, elem->AsLiteralNode()->literal());
}
+ const_list.MakeImmutable();
const_list ^= TryCanonicalize(const_list, literal_pos);
- const_list.MakeImmutable();
return new(I) LiteralNode(literal_pos, const_list);
} else {
// Factory call at runtime.
@@ -11009,8 +11009,8 @@
}
key_value_array.SetAt(i, arg->AsLiteralNode()->literal());
}
+ key_value_array.MakeImmutable();
key_value_array ^= TryCanonicalize(key_value_array, TokenPos());
- key_value_array.MakeImmutable();
// Construct the map object.
const Class& immutable_map_class = Class::Handle(I,
« no previous file with comments | « no previous file | runtime/vm/raw_object_snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698