Add list literals in js cps codegen.

Add list literals in js cps codegen.

Also split the test cases out of the test file.

R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41849

[sigurdm, 2014-11-20 12:08:06]

Patchset #1 (id:1) has been deleted

[sigurdm, 2014-11-20 12:08:59]

sigurdm@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2014-11-20 12:31:19]

LGTM.

https://codereview.chromium.org/743973002/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right):

https://codereview.chromium.org/743973002/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:182: js.ArrayInitializer
generateArrayLiteral(tree_ir.LiteralList node) {
Do you intend to share this method? Otherwise I would inline it.

https://codereview.chromium.org/743973002/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:184: List<js.ArrayElement>
entries = new List<js.ArrayElement>();
How about:
  ... entries = new List<js.ArrayElement>.generate(length, (i) {
    return new js.ArrayElement(i, visitExpression(node.values[i]));
  });

https://codereview.chromium.org/743973002/diff/20001/tests/compiler/dart2js/j...
File tests/compiler/dart2js/js_backend_cps_ir_test.dart (right):

https://codereview.chromium.org/743973002/diff/20001/tests/compiler/dart2js/j...
tests/compiler/dart2js/js_backend_cps_ir_test.dart:6: // Test that the CPS IR
code generator compiles programs as expected
'expected' -> 'and produces the expected output'?

https://codereview.chromium.org/743973002/diff/20001/tests/compiler/dart2js/j...
tests/compiler/dart2js/js_backend_cps_ir_test.dart:40: for (List<TestEntry>
tests in [basic.tests, literals.tests]) {
Could you instead leaves tests where it is as
   List<TestEntry> tests = <TestEntry>[]
     ..addAll(basic.tests)
     ..addAlll(literals.tests);

This avoids mixing the test specification from the implementation.

[sigurdm, 2014-11-20 13:20:04]

Committed patchset #2 (id:40001) manually as 41849 (presubmit successful).

[sigurdm, 2014-11-20 13:32:45]

https://codereview.chromium.org/743973002/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right):

https://codereview.chromium.org/743973002/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:182: js.ArrayInitializer
generateArrayLiteral(tree_ir.LiteralList node) {
On 2014/11/20 12:31:18, karlklose wrote:
> Do you intend to share this method? Otherwise I would inline it.

Done.

https://codereview.chromium.org/743973002/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:184: List<js.ArrayElement>
entries = new List<js.ArrayElement>();
On 2014/11/20 12:31:18, karlklose wrote:
> How about:
>   ... entries = new List<js.ArrayElement>.generate(length, (i) {
>     return new js.ArrayElement(i, visitExpression(node.values[i]));
>   });

I almost wrote that, but in the end thought that the for loop was easier to
read.

That you also asked for it convinced me to change it.

https://codereview.chromium.org/743973002/diff/20001/tests/compiler/dart2js/j...
File tests/compiler/dart2js/js_backend_cps_ir_test.dart (right):

https://codereview.chromium.org/743973002/diff/20001/tests/compiler/dart2js/j...
tests/compiler/dart2js/js_backend_cps_ir_test.dart:6: // Test that the CPS IR
code generator compiles programs as expected
On 2014/11/20 12:31:18, karlklose wrote:
> 'expected' -> 'and produces the expected output'?

Done.

https://codereview.chromium.org/743973002/diff/20001/tests/compiler/dart2js/j...
tests/compiler/dart2js/js_backend_cps_ir_test.dart:40: for (List<TestEntry>
tests in [basic.tests, literals.tests]) {
On 2014/11/20 12:31:18, karlklose wrote:
> Could you instead leaves tests where it is as
>    List<TestEntry> tests = <TestEntry>[]
>      ..addAll(basic.tests)
>      ..addAlll(literals.tests);
> 
> This avoids mixing the test specification from the implementation.

Done.