Add list literals in js cps codegen.

pkg/compiler/lib/src/js_backend/codegen/codegen.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library code_generator;
 
 import 'glue.dart';
 
 import '../../tree_ir/tree_ir_nodes.dart' as tree_ir;
 import '../../js/js.dart' as js;
@@ skipping 157 matching lines @@
   }
 
   @override
   js.Expression visitInvokeSuperMethod(tree_ir.InvokeSuperMethod node) {
     return giveup(node);
     // TODO: implement visitInvokeSuperMethod
   }
 
   @override
   js.Expression visitLiteralList(tree_ir.LiteralList node) {
-    return giveup(node);
-    // TODO: implement visitLiteralList
+    registry.registerInstantiatedClass(glue.listClass);
+    return generateArrayLiteral(node);
+  }
+
+  js.ArrayInitializer generateArrayLiteral(tree_ir.LiteralList node) {

[karlklose, 2014/11/20 12:31:18]

Do you intend to share this method? Otherwise I would inline it.

[sigurdm, 2014/11/20 13:32:44]

Done.

+    int length = node.values.length;
+    List<js.ArrayElement> entries = new List<js.ArrayElement>();

[karlklose, 2014/11/20 12:31:18]

How about:
  ... entries = new List<js.ArrayElement>.generate(length, (i) {
    return new js.ArrayElement(i, visitExpression(node.values[i]));
  });

[sigurdm, 2014/11/20 13:32:45]

I almost wrote that, but in the end thought that the for loop was easier to
read.

That you also asked for it convinced me to change it.

+    for (int i = 0; i < length; i++) {
+      entries.add(new js.ArrayElement(i, visitExpression(node.values[i])));
+    }
+    return new js.ArrayInitializer(length, entries);
   }
 
   @override
   js.Expression visitLiteralMap(tree_ir.LiteralMap node) {
     return giveup(node);
     // TODO: implement visitLiteralMap
   }
 
   @override
   js.Expression visitLogicalOperator(tree_ir.LogicalOperator node) {
@@ skipping 96 matching lines @@
   }
 
   @override
   void visitReturn(tree_ir.Return node) {
     accumulator.add(new js.Return(visitExpression(node.value)));
   }
 
   bool isNullLiteral(js.Expression exp) => exp is js.LiteralNull;
 
 }