Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 743543002: Extract incremental resolver classes into separate files. (Closed)

Created:
6 years, 1 month ago by scheglov
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Extract incremental resolver classes into separate files. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41819

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1442 lines, -1394 lines) Patch
M pkg/analyzer/lib/src/generated/engine.dart View 1 chunk +1 line, -0 lines 0 comments Download
A pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +994 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 4 chunks +0 lines, -975 lines 0 comments Download
A pkg/analyzer/test/generated/incremental_resolver_test.dart View 1 chunk +445 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 5 chunks +0 lines, -419 lines 0 comments Download
M pkg/analyzer/test/generated/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 1 month ago (2014-11-18 23:00:41 UTC) #1
Brian Wilkerson
LGTM
6 years, 1 month ago (2014-11-18 23:15:22 UTC) #2
scheglov
6 years, 1 month ago (2014-11-19 01:18:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41819 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698