Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 740273003: Incremental compiler: support optional arguments. (Closed)

Created:
6 years ago by ahe
Modified:
6 years ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, kasperl, lukechurch
Visibility:
Public.

Description

Incremental compiler: support optional arguments. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=42235

Patch Set 1 #

Patch Set 2 : Add TODO for a follow-up CL. #

Total comments: 4

Patch Set 3 : Merged with r42205. #

Patch Set 4 : Address comments and fix issues found during testing. #

Patch Set 5 : Merged with r42234. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -72 lines) Patch
M dart/pkg/compiler/lib/src/enqueue.dart View 2 chunks +10 lines, -0 lines 0 comments Download
M dart/pkg/compiler/lib/src/js_backend/backend.dart View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M dart/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M dart/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 2 3 4 2 chunks +39 lines, -14 lines 0 comments Download
M dart/pkg/compiler/lib/src/ssa/interceptor_simplifier.dart View 1 chunk +1 line, -0 lines 0 comments Download
M dart/pkg/dart2js_incremental/lib/caching_compiler.dart View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M dart/pkg/dart2js_incremental/lib/library_updater.dart View 1 2 3 6 chunks +60 lines, -6 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/js_lib/js_helper.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M dart/site/try/poi/poi.dart View 1 2 3 1 chunk +9 lines, -5 lines 0 comments Download
M dart/tests/try/web/incremental_compilation_update_test.dart View 1 2 7 chunks +9 lines, -42 lines 0 comments Download
M dart/tests/try/web/sandbox.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
ahe
6 years ago (2014-11-27 19:10:05 UTC) #2
ahe
Uploaded a new patch set.
6 years ago (2014-11-27 19:25:34 UTC) #3
Johnni Winther
lgtm https://codereview.chromium.org/740273003/diff/20001/dart/pkg/dart2js_incremental/lib/library_updater.dart File dart/pkg/dart2js_incremental/lib/library_updater.dart (right): https://codereview.chromium.org/740273003/diff/20001/dart/pkg/dart2js_incremental/lib/library_updater.dart#newcode576 dart/pkg/dart2js_incremental/lib/library_updater.dart:576: for (Selector selector in compiler.enqueuer.codegen.newlySeenSelectors) { Long line. ...
6 years ago (2014-12-05 09:48:23 UTC) #4
ahe
PTAL https://codereview.chromium.org/740273003/diff/20001/dart/pkg/dart2js_incremental/lib/library_updater.dart File dart/pkg/dart2js_incremental/lib/library_updater.dart (right): https://codereview.chromium.org/740273003/diff/20001/dart/pkg/dart2js_incremental/lib/library_updater.dart#newcode576 dart/pkg/dart2js_incremental/lib/library_updater.dart:576: for (Selector selector in compiler.enqueuer.codegen.newlySeenSelectors) { On 2014/12/05 ...
6 years ago (2014-12-09 16:28:23 UTC) #6
Johnni Winther
lgtm
6 years ago (2014-12-10 07:58:31 UTC) #7
ahe
6 years ago (2014-12-10 08:08:24 UTC) #8
Message was sent while issue was closed. 
Committed patchset #5 (id:100001) manually as 42235 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698