Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2899)

Unified Diff: dart/tests/try/web/incremental_compilation_update_test.dart

Issue 740273003: Incremental compiler: support optional arguments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Merged with r42234. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/site/try/poi/poi.dart ('k') | dart/tests/try/web/sandbox.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tests/try/web/incremental_compilation_update_test.dart
diff --git a/dart/tests/try/web/incremental_compilation_update_test.dart b/dart/tests/try/web/incremental_compilation_update_test.dart
index 3a027649e24e0480057b6157365f413d4428217f..5520f5bb7c9f2f0c92e2a687b29449967422fa09 100644
--- a/dart/tests/try/web/incremental_compilation_update_test.dart
+++ b/dart/tests/try/web/incremental_compilation_update_test.dart
@@ -1083,7 +1083,6 @@ main() {
],
// Test that named arguments can be called.
- // TODO(ahe): This test doesn't pass yet, see expectation below.
const <ProgramResult>[
const ProgramResult(
r"""
@@ -1100,12 +1099,7 @@ main() {
print('instance is null');
instance = new C();
}
- try {
- instance.foo();
- } catch (e) {
- // TODO(ahe): This try/catch shouldn't be necessary.
- print('threw');
- }
+ instance.foo();
}
""",
const <String>['instance is null', 'v1']),
@@ -1124,19 +1118,13 @@ main() {
print('instance is null');
instance = new C();
}
- try {
- instance.foo(named: 'v2');
- } catch (e) {
- // TODO(ahe): This try/catch shouldn't be necessary.
- print('threw');
- }
+ instance.foo(named: 'v2');
}
""",
- const <String>['threw']), // TODO(ahe): Expect 'v2'.
+ const <String>['v2']),
],
// Test than named arguments can be called.
- // TODO(ahe): This test doesn't pass yet, see expectation below.
const <ProgramResult>[
const ProgramResult(
r"""
@@ -1153,12 +1141,7 @@ main() {
print('instance is null');
instance = new C();
}
- try {
- instance.foo(named: 'v1');
- } catch (e) {
- // TODO(ahe): This try/catch shouldn't be necessary.
- print('threw');
- }
+ instance.foo(named: 'v1');
}
""",
const <String>['instance is null', 'v1']),
@@ -1177,19 +1160,13 @@ main() {
print('instance is null');
instance = new C();
}
- try {
- instance.foo();
- } catch (e) {
- // TODO(ahe): This try/catch shouldn't be necessary.
- print('threw');
- }
+ instance.foo();
}
""",
- const <String>['threw']),
+ const <String>['v2']),
],
// Test that an instance tear-off with named parameters can be called.
- // TODO(ahe): This test doesn't pass yet, see expectation below.
const <ProgramResult>[
const ProgramResult(
r"""
@@ -1206,12 +1183,7 @@ main() {
print('closure is null');
closure = new C().foo;
}
- try {
- closure();
- } catch (e) {
- // TODO(ahe): This try/catch shouldn't be necessary.
- print('threw');
- }
+ closure();
}
""",
const <String>['closure is null', 'v1']),
@@ -1230,15 +1202,10 @@ main() {
print('closure is null');
closure = new C().foo;
}
- try {
- closure(named: 'v2');
- } catch (e) {
- // TODO(ahe): This try/catch shouldn't be necessary.
- print('threw');
- }
+ closure(named: 'v2');
}
""",
- const <String>['threw']), // TODO(ahe): Expect 'v2'.
+ const <String>['v2']),
],
/*
« no previous file with comments | « dart/site/try/poi/poi.dart ('k') | dart/tests/try/web/sandbox.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698