Issue 739883002: `this` in js-cps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 739883002: `this` in js-cps. (Closed)

Created:
6 years, 1 month ago by sigurdm

Modified:
6 years, 1 month ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, Karl Klose

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	pkg/compiler/lib/src/js_backend/codegen/codegen.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

floitsch

LGTM. However, I expect the semantic meaning of 'this' to change.

6 years, 1 month ago (2014-11-19 12:28:02 UTC) #3

sigurdm

6 years, 1 month ago (2014-11-19 12:47:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 41829 (presubmit successful).