pkg/compiler/lib/src/js_backend/codegen/codegen.dart - Issue 739883002: `this` in js-cps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 739883002: `this` in js-cps. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Add todo Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

index db1d80479a40fefbb0a8f3c8f00ad1e4dce6e5f2..baad66255e78d7c1865aeee42f85975d768eecb8 100644

--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

@@ -200,8 +200,8 @@ class CodeGenerator extends tree_ir.Visitor<dynamic, js.Expression> {

@override

js.Expression visitThis(tree_ir.This node) {

- return giveup(node);

- // TODO: implement visitThis

+ // TODO(sigurdm): Inside a js closure this will not work.

+ return new js.This();

}

@override

« no previous file with comments | « no previous file | no next file » | no next file with comments »