Issue 738453002: Add missing verified write on x64; extend test coverage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 738453002: Add missing verified write on x64; extend test coverage (Closed)

Created:
6 years, 1 month ago by koda

Modified:
6 years, 1 month ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add missing verified write on x64; extend test coverage On x64, StoreInstanceField and StoreIndexed sometimes used Assembler::StoreObject to store constants directly into heap objects. This method is unaware of the write barrier. Fix this by adding a write-barrier-aware method, like we already have on ia32. Generally, we should consider distinguishing more clearly between stack stores and heap stores, for instance by adding HeapAddress/StackAddress types. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=41808

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -8 lines)			Patch
M	runtime/vm/assembler_x64.h	View	1 2 3	6 chunks	+10 lines, -1 line	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1 2 3	4 chunks	+22 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3	2 chunks	+4 lines, -3 lines	0 comments	Download
M	tests/lib/convert/streamed_conversion_json_utf8_decode_test.dart	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/standalone/verified_mem_test.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

koda

6 years, 1 month ago (2014-11-18 16:36:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as r41808 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 738453002: Add missing verified write on x64; extend test coverage (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages