Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 738453002: Add missing verified write on x64; extend test coverage (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_x64.cc
===================================================================
--- runtime/vm/intermediate_language_x64.cc (revision 41792)
+++ runtime/vm/intermediate_language_x64.cc (working copy)
@@ -1253,7 +1253,7 @@
__ StoreIntoObject(array, element_address, value);
} else if (locs()->in(2).IsConstant()) {
const Object& constant = locs()->in(2).constant();
- __ StoreObject(element_address, constant, PP);
+ __ StoreIntoObjectNoBarrier(array, element_address, constant, PP);
} else {
Register value = locs()->in(2).reg();
__ StoreIntoObjectNoBarrier(array, element_address, value);
@@ -1857,8 +1857,9 @@
CanValueBeSmi());
} else {
if (locs()->in(1).IsConstant()) {
- __ StoreObject(FieldAddress(instance_reg, offset_in_bytes_),
- locs()->in(1).constant(), PP);
+ __ StoreIntoObjectNoBarrier(instance_reg,
+ FieldAddress(instance_reg, offset_in_bytes_),
+ locs()->in(1).constant(), PP);
} else {
Register value_reg = locs()->in(1).reg();
__ StoreIntoObjectNoBarrier(instance_reg,
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | tests/lib/convert/streamed_conversion_json_utf8_decode_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698